[Fix #22254] Put real storage behind PM_STRING_EMPTY - #4228
Merged
Merged
Conversation
Some places memcpy the source, and NULL there is undefined behaviour. Fixes https://bugs.ruby-lang.org/issues/22254
Earlopain
force-pushed
the
empty-string-with-storage
branch
from
September 14, 2026 12:16
b37151f to
839c1a1
Compare
Earlopain
changed the title
PM_STRING_EMPTYPM_STRING_EMPTY
Earlopain
changed the title
PM_STRING_EMPTYPM_STRING_EMPTY
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Sep 23, 2026
storage behind `PM_STRING_EMPTY` (ruby/prism#4228) Some places memcpy the source, and NULL there is undefined behaviour. Fixes https://bugs.ruby-lang.org/issues/22254 ruby/prism@d0b36ceb34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places memcpy the source, and NULL there is undefined behaviour.
Fixes https://bugs.ruby-lang.org/issues/22254